♻️ (game.py, signals.py): Refactor comparison operators for better readability
🔧 (apps.py): Import signals in ready method to ensure signals are loaded when the app starts 🔧 (pyproject.toml): Add PGH004 to lint ignore list to avoid linting errors related to PostgreSQL-specific code
This commit is contained in:
@@ -46,7 +46,6 @@ class GameEventResource(APIView):
|
||||
|
||||
def post(self, request, game_id):
|
||||
"""Creates a new event"""
|
||||
|
||||
try:
|
||||
game = Game.objects.get(pk=game_id)
|
||||
except Game.DoesNotExist:
|
||||
|
||||
@@ -7,4 +7,4 @@ class GameConfig(AppConfig):
|
||||
verbose_name_plural = 'Games'
|
||||
|
||||
def ready(self):
|
||||
pass
|
||||
from game import signals # noqa
|
||||
|
||||
@@ -8,7 +8,7 @@ from .models import EventTypes, Game, GameEvent, GameStatuses
|
||||
@receiver(post_save, sender=Game)
|
||||
def game_start(sender, signal, instance, **kwargs):
|
||||
"""If the game was just created, insert the first event START_GAME"""
|
||||
if not instance.status == GameStatuses.NOT_PLAYED:
|
||||
if instance.status != GameStatuses.NOT_PLAYED:
|
||||
return
|
||||
GameEvent.objects.get_or_create(game=instance, type=EventTypes.START_GAME)
|
||||
|
||||
@@ -16,7 +16,7 @@ def game_start(sender, signal, instance, **kwargs):
|
||||
@receiver(pre_save, sender=GameEvent)
|
||||
def identify_click_event(sender, signal, instance, **kwargs):
|
||||
"""Verify what is on the naive click: mine, point or empty"""
|
||||
if not instance.type == EventTypes.CLICK_NAIVE:
|
||||
if instance.type != EventTypes.CLICK_NAIVE:
|
||||
return
|
||||
|
||||
if instance.row is None and instance.col is None:
|
||||
|
||||
@@ -74,6 +74,7 @@ lint.ignore = [
|
||||
"RUF012",
|
||||
"N806",
|
||||
"ARG002",
|
||||
"PGH004",
|
||||
"N805", # Missing type annotation for self in method (Pydantic don't like this)
|
||||
"SIM108", # Use ternary operator {contents} instead of if-else-block
|
||||
"RUF009", # Missing dataclass field.
|
||||
|
||||
Reference in New Issue
Block a user